Fix reflective lifetime issues #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They accidentally ended up in the ConnectionEvaluator TEST_CASE.
With the new connectReflective capability, slots can disconnect themselves. Make sure that this doesn't cause them to delete themselves while they're still running.
This allows slots to safely call disconnect on their own ConnectionHandle if they are using a reflective connection.
seanharmer
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing #21 , I noticed that the issue discussion still included some concerns about the lifetime of reflective connections that we didn't address in the initial PR ( #70 ).
This PR adds a test to confirm this is indeed an issue (if you checkout 030fcf4 without the fix, it should SegFault or fail).
The last commit in this PR then fixes the issue by deferring disconnection until the emit is finished.