Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use major-only version for github-pages-deploy-action #287

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jul 14, 2023

github-pages-deploy-action provides a major-only version tag for their action, which reduces the version churn.

@twyatt twyatt requested a review from a team as a code owner July 14, 2023 17:51
@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jul 14, 2023
@twyatt twyatt enabled auto-merge (squash) July 14, 2023 17:51
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #287 (0ba0455) into main (1c1547e) will decrease coverage by 25.14%.
The diff coverage is 47.50%.

❗ Current head 0ba0455 differs from pull request most recent head 34063b7. Consider uploading reports for the commit 34063b7 to get more accurate results

@@              Coverage Diff              @@
##               main     #287       +/-   ##
=============================================
- Coverage     94.44%   69.30%   -25.14%     
=============================================
  Files            13        9        -4     
  Lines           126      101       -25     
  Branches          8        2        -6     
=============================================
- Hits            119       70       -49     
- Misses            6       31       +25     
+ Partials          1        0        -1     
Impacted Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)

... and 6 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Test Results

  96 files    96 suites   8s ⏱️
833 tests 824 ✔️   9 💤 0
850 runs  836 ✔️ 14 💤 0

Results for commit 34063b7.

♻️ This comment has been updated with latest results.

@twyatt twyatt merged commit 3cdd6f0 into main Jul 17, 2023
3 checks passed
@twyatt twyatt deleted the twyatt/github-pages-deploy-action branch July 17, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants