KSP Migration #35
KSP Migration #35
Conversation
|
I'm realizing this repo sprung up before the |
This was done to solve issues with stubs across multiple modules. KSP was not properly carrying annotation arguments across the module boundary (that is, even though we could see annotations on the stub class, @Exercise.params was artificially empty).
|
Most recent change is a workaround for google/ksp#356 |
Is the plan to eventually support it again, or are we abandoning AndroidX result support? |
The plan is definitely to support it again. It just didn't feel right to keep it considering that it was both some of the only generated code without tests, and also not generating code compatible with the 1.x releases of androidx result passing. |
|
Im not sure who else this would be useful for (highly likely just for myself) but I found https://github.com/google/ksp/blob/master/docs/why-ksp.md very informative for a high level background on KSPs. |
|
Probably learned more from this PR than I am able to offer in advice or criticism, and I don't want to hold it back any longer. Maybe discuss more about your findings on working with KSPs at the Kotlin team meeting today? |
There was a problem hiding this comment.
Pass 3/x
I know my review is taking quite a while. Really wanting to understand this stuff. It is super cool too! Let me know if there is any urgency to getting this in and I'll prioritize and/or review with less detail/questions.
A lot of the slow down of my review is trying to learn it as I review it. So, I also apologize for asking a lot of questions that purely stem from me having zero experience with KSP.
| @@ -0,0 +1,5 @@ | |||
| plugins { | |||
| kotlin("jvm") | |||
| // Not real code, so not worrying about coverage or lints. | |||
There was a problem hiding this comment.
Not sure you really need this comment. 🤷
Major Breaking Changes
kaptsupport in favor ofkspsupportOther Important Changes
XyzParamsclass is now generated in the stub module, accepting anyActivityin its constructor. This is a workaround for a bug in KSP, and should be revertible pre-1.0 for stronger type safety.build.gradle.ktsand abuildSrcmoduleCloses #26.