-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Search Support #576
Draft
CGBassPlayer
wants to merge
16
commits into
JupiterBroadcasting:develop
Choose a base branch
from
CGBassPlayer:pagefind-search
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Initial Search Support #576
CGBassPlayer
wants to merge
16
commits into
JupiterBroadcasting:develop
from
CGBassPlayer:pagefind-search
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGBassPlayer
added
enhancement
New feature, enhancement, or request
in progress
currently being worked on
UX
related to user experience
labels
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature, enhancement, or request
in progress
currently being worked on
UX
related to user experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Adds initial support for searching the website using Pagefind. This initial implementation uses the default UI provided by the app and I have only done some color changes to make it readable on the site. The plan is to eventually update it to use a custom UI to match the style of the rest of the website (I am thinking of reusing the cards).
To prevent unused generated pages (See #539), the current implementation uses
data-pagefind-body
to mark what parts of the site are indexed in the search.