Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added runners for vscode #479

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

timlinux
Copy link
Contributor

If you are using VSCode then it is nice to be able to run the make tasks from within the IDE nicely:

image

You can access them from the Run and Debug Tab (1) and then the Run tool (2).

See #467 for preceding discussion.

@gerbrent gerbrent added dev Related to the development environment enhancement New feature, enhancement, or request feedback requested labels Oct 29, 2022
@CGBassPlayer CGBassPlayer self-requested a review October 30, 2022 03:54
@CGBassPlayer
Copy link
Collaborator

CGBassPlayer commented Oct 30, 2022

I plan to look into this soon. The main things I’m looking for are:

  • Will this config mess with peoples current project configuration?
  • Does this configuration work on Windows and Linux?
  • Will others adding custom run configurations (like using Hugo on host instead of docker) have a high likelihood on sneaking into a commit and changing others’ configs?

While I am looking at these, how do other people feel about keeping run configuration for editors and IDEs in the repo?

If we decide yes, I can add my current configuration for Fleet as well once it is out of public preview (still kind of buggy in it’s current state). I think those 2 and maybe a stripped down .idea folder for more serious IDEs (PyCharm is the one that comes to mind.

@elreydetoda
Copy link
Collaborator

So, personally I think this could lead down a very long rabbit hole 😅.

A good compromise (IMO) would be to have something like a .ide folder and then we can put all the custom configurations there (inside their respective folders). I think keeping those configurations lean (like @CGBassPlayer player had mentioned with the .idea folder) would be a requirement. This would allow people to just copy the folder to the expected location easily and not allow the:

high likelihood on sneaking into a commit and changing others’ configs

to happen.

@gerbrent
Copy link
Collaborator

gerbrent commented Nov 3, 2022

great suggestion! I say lets implement this path, and update the docs to reflect this option/feature/asset is available too

Copy link
Collaborator

@CGBassPlayer CGBassPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @elreydetoda's suggestion of creating a .ide folder with the .vscode folder within it. That will allow new contributors to have the default commands, but not worry about writing over others IDE configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Related to the development environment enhancement New feature, enhancement, or request feedback requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants