Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $bytes_received to log number of (body) bytes read from client, fixes #892. #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fredrikekre
Copy link
Member

NGINX $bytes_received includes header bytes as well, I think (http://nginx.org/en/docs/stream/ngx_stream_core_module.html#var_bytes_received) so perhaps this should be called $body_bytes_receieved? Or perhaps this should be updated to also count header bytes. (NGINX doesn't have $body_bytes_receieved.)

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (cf706bc) to head (b2f9e7f).
Report is 176 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   80.12%   80.35%   +0.23%     
==========================================
  Files          36       36              
  Lines        2878     2897      +19     
==========================================
+ Hits         2306     2328      +22     
+ Misses        572      569       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants