Skip to content

Commit

Permalink
Merge pull request #360 from Wynand/wy/clean-benchmark
Browse files Browse the repository at this point in the history
Rebuild TZData before benchmarks
  • Loading branch information
iamed2 authored Oct 7, 2021
2 parents ae1e583 + 9aa7241 commit 0e67ab1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ jobs:
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "origin/HEAD", verbose=false))'
env:
TZDATA_VERSION: 2016j # Matches tzdata version used in tests
doctest:
name: Documentation - Julia ${{ matrix.version }}
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "TimeZones"
uuid = "f269a46b-ccf7-5d73-abea-4c690281aa53"
authors = ["Curtis Vogt <[email protected]>"]
version = "1.5.7"
version = "1.5.8"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
6 changes: 5 additions & 1 deletion benchmark/benchmarks.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using BenchmarkTools
using Dates: Period, Day, Hour, DateFormat, @dateformat_str
using TimeZones
using TimeZones.TZData: parse_components
using TimeZones.TZData: parse_components, build
using Test: GenericString

const SUITE = BenchmarkGroup()
Expand All @@ -11,6 +11,10 @@ function gen_range(num_units::Period, tz::TimeZone)
return StepRange(zdt, oneunit(num_units), zdt + num_units)
end

# Ensure that when comparing benchmarks
# That the compiled TZData is compatible with this version
build("2016j") # version consistent with tests

include("tzdata.jl")
include("interpret.jl")
include("zoneddatetime.jl")
Expand Down

3 comments on commit 0e67ab1

@omus
Copy link
Member

@omus omus commented on 0e67ab1 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrar register

@omus
Copy link
Member

@omus omus commented on 0e67ab1 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/46685

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.5.8 -m "<description of version>" 0e67ab104ba80d315f3514798a36423ee96fdc6a
git push origin v1.5.8

Please sign in to comment.