-
-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bugfix: ematcher now returns hash of constants instead of index of en…
…ode in class when using type predicates in dynamic rules.
- Loading branch information
Showing
2 changed files
with
14 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dd5848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me and this looks like it solves the issue, but I guess the larger issue is that we need documentation for exactly what the UInt128s pushed to the ematch_buffer are supposed to represent? This is what caused the issue in the first place, because I think different bits of code were making slightly different assumptions.
7dd5848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is potentially confusing.
I have the feeling that this could be the cause for failing tests in CAS and lambda_theory
7dd5848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a PR for this? @gkronber
7dd5848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. There is one remaining failing test for CAS.
This change is included in #249 . If necessary I can prepare the changes for ematch_compiler in a separate branch.