Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional test cases to improve coverage #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add additional test cases to improve coverage #50

wants to merge 1 commit into from

Conversation

quinnj
Copy link

@quinnj quinnj commented Apr 26, 2021

No description provided.

@ScottPJones
Copy link
Member

ScottPJones commented May 13, 2021 •
edited
Loading

This needs to have @static if VERSION >= ... ... end around the tests for parsing arguments at the end of a string.
That causes the tests to fail on older versions of Julia (before Jeff merged in the change I did to make numbers work as string arguments, not just things that looked like symbols)
(and thanks for the extra tests! It's appreciated!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinnj @ScottPJones