Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Apple silicon to CI #760

Merged
merged 3 commits into from
Mar 25, 2024
Merged

add Apple silicon to CI #760

merged 3 commits into from
Mar 25, 2024

Conversation

palday
Copy link
Member

@palday palday commented Mar 25, 2024

no release necessary

I like the idea of testing another CPU architecture to work as further sanity check on our numerical tolerances.

@palday palday requested a review from dmbates March 25, 2024 17:26
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (beaaa36) to head (eadf8e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          34       34           
  Lines        3358     3358           
=======================================
  Hits         3255     3255           
  Misses        103      103           
Flag Coverage Δ
current 96.87% <ø> (+0.05%) ⬆️
minimum 96.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@palday palday merged commit c71c3b6 into main Mar 25, 2024
11 of 12 checks passed
@palday palday deleted the pa/m1 branch March 25, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants