fix simulate when only the non pivoted coefs are provided

JuliaStats · Mar 20, 2024 · 664c003 · 664c003
1 parent 0d3cd4b
commit 664c003
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/simulate.jl b/src/simulate.jl
@@ -157,10 +157,10 @@ function simulate!(
     θ = convert(Vector{T}, θ)
     isempty(θ) || setθ!(m, θ)
 
-    # if length(β) ≠ length(m.feterm.piv)
-    #     padding = length(model.feterm.piv) - m.feterm.rank
-    #     append!(β, fill(-0.0, padding))
-    # end
+    if length(β) ≠ length(m.feterm.piv)
+        β = invpermute!(copyto!(fill(-0.0, length(m.feterm.piv)), β), 
+                    m.feterm.piv)
+    end
 
     # initialize y to standard normal
     randn!(rng, y)
@@ -247,11 +247,11 @@ function _simulate!(
 
     d = m.resp.d
 
-    # if length(β) ≠ length(m.feterm.piv)
-    #     padding = length(model.feterm.piv) - m.feterm.rank
-    #     append!(β, fill(-0.0, padding))
-    # end
-
+    if length(β) ≠ length(m.feterm.piv)
+        β = invpermute!(copyto!(fill(-0.0, length(m.feterm.piv)), β), 
+                    m.feterm.piv)
+    end
+    
     fast = (length(m.θ) == length(m.optsum.final))
     setpar! = fast ? setθ! : setβθ!
     params = fast ? θ : vcat(β, θ)