readability

Co-authored-by: Alex Arslan <[email protected]>
JuliaStats · Mar 25, 2024 · 41609b5 · 41609b5
1 parent 4d8fb60
commit 41609b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/generalizedlinearmixedmodel.jl b/src/generalizedlinearmixedmodel.jl
@@ -426,7 +426,7 @@ function GeneralizedLinearMixedModel(
             LMM.optsum,
         )
     end
-    X = view(LMM.X, :, 1:(LMM.feterm.rank))
+    X = fullrankx(LMM.feterm)
     # if the response is constant, there's no point (and this may even fail)
     # we allow this instead of simply failing so that a constant response can
     # be used as the starting point to simulation where the response will be
@@ -794,7 +794,7 @@ function updateη!(m::GeneralizedLinearMixedModel{T}) where {T}
     b = m.b
     u = m.u
     reterms = m.LMM.reterms
-    mul!(η, view(modelmatrix(m), :, 1:(m.LMM.feterm.rank)), m.β)
+    mul!(η, view(modelmatrix(m), :, 1:rank(m)), m.β)
     for i in eachindex(b)
         mul!(η, reterms[i], vec(mul!(b[i], reterms[i].λ, u[i])), one(T), one(T))
     end

diff --git a/test/bootstrap.jl b/test/bootstrap.jl
@@ -235,7 +235,7 @@ end
             @test all(boot.β) do nt
                 # if we're the dropped coef, then we must be -0.0
                 # need isequal because of -0.0
-               return nt.coefname != dropped_coef || isequal(nt.β, -0.0)
+                return nt.coefname != dropped_coef || isequal(nt.β, -0.0)
             end
 
             yc = simulate(StableRNG(1), model; β=coef(model))