Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse * sparse fixes #55

Merged
merged 5 commits into from
Jan 13, 2025
Merged

sparse * sparse fixes #55

merged 5 commits into from
Jan 13, 2025

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Jan 7, 2025

  • Fix sparse * sparse overload was not constrained to the matrices with BlasFloat eltype
  • Fix special * special: these overloads were not generated, but the unit tests have not detected this error, because in those tests the matrices were not made special (fixed now)

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (fec49ef) to head (cfb5cb2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   44.39%   44.57%   +0.18%     
==========================================
  Files           8        8              
  Lines        1489     1494       +5     
==========================================
+ Hits          661      666       +5     
  Misses        828      828              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyst alyst requested a review from amontoison January 7, 2025 03:35
src/interface.jl Outdated Show resolved Hide resolved
Co-authored-by: Kristoffer Carlsson <[email protected]>
@ViralBShah
Copy link
Member

ViralBShah commented Jan 13, 2025

Merge?

Please do tag a new release too.

@amontoison amontoison merged commit 78c0f41 into master Jan 13, 2025
10 checks passed
@amontoison amontoison deleted the check_spXsp_eltypes branch January 13, 2025 09:34
@amontoison
Copy link
Member

Thank you @alyst 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants