-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse * sparse fixes #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alyst
commented
Jan 7, 2025
•
edited
Loading
edited
- Fix sparse * sparse overload was not constrained to the matrices with BlasFloat eltype
- Fix special * special: these overloads were not generated, but the unit tests have not detected this error, because in those tests the matrices were not made special (fixed now)
wrap tested matrices into Special() calll
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 44.39% 44.57% +0.18%
==========================================
Files 8 8
Lines 1489 1494 +5
==========================================
+ Hits 661 666 +5
Misses 828 828 ☔ View full report in Codecov by Sentry. |
KristofferC
reviewed
Jan 7, 2025
Co-authored-by: Kristoffer Carlsson <[email protected]>
Merge? Please do tag a new release too. |
amontoison
approved these changes
Jan 13, 2025
Thank you @alyst 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.