Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks2 #69

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix benchmarks2 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c5d1c
Make benchmark use old FittedItemBanks interface
frankier Aug 30, 2024
338feb2
Make pr benchmark action add extra packages needed
frankier Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/benchmark_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ jobs:
echo $PATH
ls -l ~/.julia/bin
mkdir results
benchpkg ${{ steps.extract-package-name.outputs.package_name }} --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --url=${{ github.event.repository.clone_url }} --bench-on="${{github.event.repository.default_branch}}" --output-dir=results/ --tune
benchpkg ${{ steps.extract-package-name.outputs.package_name }} --add 'StatsBase,FittedItemBanks,PsychometricsBazaarBase' --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --url=${{ github.event.repository.clone_url }} --bench-on="${{github.event.repository.default_branch}}" --output-dir=results/ --tune
- name: Create plots from benchmarks
run: |
mkdir -p plots
benchpkgplot ${{ steps.extract-package-name.outputs.package_name }} --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --npart=10 --format=png --input-dir=results/ --output-dir=plots/
benchpkgplot ${{ steps.extract-package-name.outputs.package_name }} --add 'StatsBase,FittedItemBanks,PsychometricsBazaarBase' --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --npart=10 --format=png --input-dir=results/ --output-dir=plots/
- name: Upload plot as artifact
uses: actions/upload-artifact@v2
with:
name: plots
path: plots
- name: Create markdown table from benchmarks
run: |
benchpkgtable ${{ steps.extract-package-name.outputs.package_name }} --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --input-dir=results/ --ratio > table.md
benchpkgtable ${{ steps.extract-package-name.outputs.package_name }} --add 'StatsBase,FittedItemBanks,PsychometricsBazaarBase' --rev="${{github.event.repository.default_branch}},${{github.event.pull_request.head.sha}}" --input-dir=results/ --ratio > table.md
echo '### Benchmark Results' > body.md
echo '' >> body.md
echo '' >> body.md
Expand Down
2 changes: 1 addition & 1 deletion benchmark/benchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ SUITE["next_item_rules"] = BenchmarkGroup()
#prepare_0(ability_estimator)
function prepare_4pls(group)
rng = Xoshiro(42)
(; item_bank, abilities, responses) = dummy_full(
(item_bank, abilities, responses) = dummy_full(
rng,
SimpleItemBankSpec(StdModel4PL(), OneDimContinuousDomain(), BooleanResponse());
num_questions = 20,
Expand Down
Loading