Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust lower compats for compatibility with julia-1.11 #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fhagemann
Copy link
Contributor

Here are some changes to the lower package compats required to work on julia-1.11:

These changes should resolve the failing Downgrade tests.
The only question remaining: do we want an explicit version requirement for SpecialFunctions ≥ 0.9 via weak dependencies here?

@oschulz
Copy link
Member

oschulz commented Oct 10, 2024

These changes should resolve the failing Downgrade tests.

Should we maybe run Downgrade on Julia v1.10 LTS - so kinda downgrade Julia as well?

@fhagemann
Copy link
Contributor Author

We could. Or is there a possibility to have different Project.toml for each Julia version?

@oschulz
Copy link
Member

oschulz commented Oct 11, 2024

Or is there a possibility to have different Project.toml for each Julia version

No, that's not possible.

@fhagemann
Copy link
Contributor Author

I relaxed the package compatibility requirements by setting strict: false in the Downgrade CI.

Final changes:

  • I adjusted the lower compat of FillArrays to 0.13.
  • I adjusted the lower compat of FFTW to 1.2 to not depend on BinaryProvider.
  • Downgrade will now run BOTH on 1.10 and on 1.

@oschulz If all tests pass, this PR should be ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants