Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sin_rev and cos_rev #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sin_rev and cos_rev #34

wants to merge 1 commit into from

Conversation

dpsanders
Copy link
Member

No description provided.

@lucaferranti
Copy link
Member

@lbenet @dpsanders I rebased this, but it seems it breaks a bunch of IEEE tests for sin and cos

@lucaferranti
Copy link
Member

I'm also surprised that sin_rev(0..0, 0..0) wasn't a test in the IEEE testsuite, it feels like an important corner case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpsanders @lucaferranti