Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce clcall for ccall-like kernel invocation. #228

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 12, 2024

By passing the tuple type, OpenCL.jl can do proper argument conversions, and doesn't rely on the type of the arguments happening to be correct (which can be fragile, e.g., when using literals). In addition, this makes it possible to pass CLArrays to kernels expecting a pointer, without having to explicitly access the underlying buffer.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (3204e6a) to head (1df2bef).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   76.96%   77.24%   +0.27%     
==========================================
  Files           3        3              
  Lines         165      167       +2     
==========================================
+ Hits          127      129       +2     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit c544319 into master Sep 12, 2024
5 checks passed
@maleadt maleadt deleted the tb/clcall branch September 12, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant