Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nonblocking) implement non blocking mode for connections #280

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pankgeorg
Copy link

Towards making this work https://github.com/TechEmpower/FrameworkBenchmarks/pull/8370/files (more context)

I'm trying to remove any blocking calls from anywhere in the Julia Web stack. Though this may be minor, I think it's not a bad idea to have it around!

I'll have numbers regarding whether this works soon™️ 😅

TODO (@iamed2 please add more as you please)

  • include in tests
  • benchmark
  • add guide in README.md

Copy link
Collaborator

@iamed2 iamed2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what the test results will reveal (mostly whether any other places need a call to PQflush).

I do know the copy functions also need a flush dance: https://www.postgresql.org/docs/current/libpq-copy.html#LIBPQ-COPY-SEND

src/asyncresults.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/connections.jl Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/asyncresults.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
src/connections.jl Outdated Show resolved Hide resolved
@pankgeorg pankgeorg marked this pull request as ready for review September 18, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants