Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation and Test-Case for DataFrame Upload using CSV.RowIterator #186

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lungben
Copy link

@lungben lungben commented Jun 26, 2020

Follow-up of
#172

A test case for uploading a DataFrame using the CSV.RowIterator and a corresponding example to the documentation has been added.

I had to update the version number of DataFrames so that it is compatible to the most recent version of CSV.jl, but this should not be an issue because it is only a test dependency and all tests are still working for me.

test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@lungben
Copy link
Author

lungben commented Jul 7, 2020

@iamed2 thanks for your feedback!
I incorporated your suggestions, please let me know if something is missing.

@cmey
Copy link

cmey commented Dec 20, 2020

bump, this looks good and could use this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants