Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Git_jll instead of relying on system install #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use Git_jll instead of relying on system install #10

wants to merge 3 commits into from

Conversation

omus
Copy link
Member

@omus omus commented Mar 4, 2021 •
edited
Loading

Fixes: #7

@omus
Copy link
Member Author

omus commented Mar 4, 2021

bors try

bors bot added a commit that referenced this pull request Mar 4, 2021
@bors
Try #10:
a2eaa78
@bors
Copy link
Contributor

bors bot commented Mar 4, 2021

try

Build failed:

@omus
Copy link
Member Author

omus commented Mar 4, 2021

bors try

bors bot added a commit that referenced this pull request Mar 4, 2021
@bors
Try #10:
b57e14b
@bors
Copy link
Contributor

bors bot commented Mar 4, 2021

try

Build failed:

@omus
Copy link
Member Author

omus commented Mar 5, 2021

bors try

bors bot added a commit that referenced this pull request Mar 5, 2021
@bors
Try #10:
47c8e9c
@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

try

Build failed:

@omus
Copy link
Member Author

omus commented Mar 5, 2021

Things are working now. Unfortunately Git_jll requires Julia 1.3 which means this PR will probably just sit here until we decide to drop Julia 1.0 here.

@mattBrzezinski
Copy link
Member

mattBrzezinski commented Mar 5, 2021 •
edited
Loading

Things are working now. Unfortunately Git_jll requires Julia 1.3 which means this PR will probably just sit here until we decide to drop Julia 1.0 here.

Since this is a new package to the open source community, and internally at Invenia we are using Julia1.5, can we not proceed?

EDIT: I guess we already made this publicly available in the registry. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Git_jll
2 participants
@omus @mattBrzezinski