Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #125 for real numbers #126

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Fix for issue #125 for real numbers #126

merged 2 commits into from
Aug 18, 2024

Conversation

Jilhg
Copy link
Contributor

@Jilhg Jilhg commented Aug 17, 2024

This fixes issue #125, for real PeriodicSegment and real values x. It overloads

indomain(x::R1, d::PeriodicSegment{R2}) where {R1<:Real,R2<:Real} = true

I also added some testcases.

For all other types of numbers (e.g. ComplexF64) or all other PeriodicDomains the old definition still applies, and so issue #125 is potentially still not resolved for them.

@jishnub
Copy link
Member

jishnub commented Aug 17, 2024

Perhaps we should use something like isfinite(x) instead of true? Don't want values like NaN to be indomain.

@Jilhg
Copy link
Contributor Author

Jilhg commented Aug 17, 2024

I agree, thank you. I added this.

@jishnub jishnub merged commit e8b45c8 into JuliaApproximation:master Aug 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants