-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support version 0 (zookeeper) and version 1 (kafka) protocol for commit offsets. #48
base: master
Are you sure you want to change the base?
Conversation
protocol for commit offsets.
Nice Ill have a look |
@nrandell do you have a consumer written that is implementing the ConsumerCoordinator offset management APIs? Or was this patch just to get the offset commits working with 8.2? |
This was just to get the commits working.
|
@nrandell i have pulled this in to the integration branch. But I don't have a kafka 8.2 to test it against. I'll get it setup and tested on Tuesday. I think I need to start writing up some actual documentation for this now too. Specially with multiple versions coming out. |
Basic support working and unit tests running ok.
One unit test fails though - ProducerConsumerIntegrationTests - ConsumerShouldMoveToNextAvailableOffsetwhenQueryingForNextMessage is failing, but I don't think this is related.