Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version 0 (zookeeper) and version 1 (kafka) protocol for commit offsets. #48

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nrandell
Copy link

@nrandell nrandell commented Apr 2, 2015

Basic support working and unit tests running ok.

One unit test fails though - ProducerConsumerIntegrationTests - ConsumerShouldMoveToNextAvailableOffsetwhenQueryingForNextMessage is failing, but I don't think this is related.

@Jroland
Copy link
Owner

Jroland commented Apr 2, 2015

Nice Ill have a look

@Jroland
Copy link
Owner

Jroland commented Apr 2, 2015

@nrandell do you have a consumer written that is implementing the ConsumerCoordinator offset management APIs? Or was this patch just to get the offset commits working with 8.2?

@nrandell
Copy link
Author

nrandell commented Apr 3, 2015

This was just to get the commits working.
On 2 Apr 2015 10:27 pm, "James Roland" [email protected] wrote:

@nrandell https://github.com/nrandell do you have a consumer written
that is implementing the ConsumerCoordinator offset management APIs? Or was
this patch just to get the offset commits working with 8.2?


Reply to this email directly or view it on GitHub
#48 (comment).

@Jroland
Copy link
Owner

Jroland commented Apr 5, 2015

@nrandell i have pulled this in to the integration branch. But I don't have a kafka 8.2 to test it against. I'll get it setup and tested on Tuesday. I think I need to start writing up some actual documentation for this now too. Specially with multiple versions coming out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants