-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart interactions #72
base: master
Are you sure you want to change the base?
Conversation
I tried to add an Concerned commit - ffceb1f @Jpadilla1 would you be able to help on this? The intermixing of Swift and Objective-C code is making it more confusing for a noob like me. |
So I made a little progress. In the commit dd3fe04, I was able to get hold of the |
77851eb
to
0784dec
Compare
Selection/unselection selectors work for LineChart now. |
@Jpadilla1 did you get a chance to look at this? |
This a great PR, congrats. |
Sorry for the late response @prithsharma, will take a look at it today. |
@Jpadilla1 did you get a chance to look at this one? |
@prithsharma cool, and I notice the author don't have enough time to continue maintain the project from this issue :( |
@prithsharma chartValueSelected listener is also implemented at https://github.com/wuxudong/react-native-charts-wrapper . and it is shared among all chart type. may be you will want to take a look |
Work in progress
Since I am not very familiar with both Objective-C and Swift, bootstrapping PR for early comments. Apart from general comments, looking for suggestions on the question below: