Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for ! and ? and add tests #114

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cparros
Copy link

@cparros cparros commented Feb 16, 2024

PR Checklist

Overview

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6888be1) 86.36% compared to head (607e9c3) 75.37%.
Report is 23 commits behind head on main.

Files Patch % Lines
src/sentences-per-line.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #114       +/-   ##
===========================================
- Coverage   86.36%   75.37%   -11.00%     
===========================================
  Files           2        2               
  Lines         132      134        +2     
  Branches       25       25               
===========================================
- Hits          114      101       -13     
- Misses         18       33       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not detect sentences ending with ! or ?
1 participant