Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not detect sentences ending with ! or ? #22

Open
JoshuaKGoldberg opened this issue Dec 5, 2022 · 0 comments · May be fixed by #114
Open

Does not detect sentences ending with ! or ? #22

JoshuaKGoldberg opened this issue Dec 5, 2022 · 0 comments · May be fixed by #114
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Right now only . is detected:

https://github.com/JoshuaKGoldberg/sentences-per-line/blob/bea2b68340989f637bda693fea548bd874a029be/index.js#L88

So this test case does not work:

Hello world! Another sentence!

How unfortunate.
@JoshuaKGoldberg JoshuaKGoldberg added the good first issue Good for newcomers, please hop on! label Dec 5, 2022
@JoshuaKGoldberg JoshuaKGoldberg transferred this issue from JoshuaKGoldberg/sentences-per-line-old Nov 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Nov 12, 2023
@cparros cparros linked a pull request Feb 16, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for ! and ? and add tests cparros/sentences-per-line
1 participant
@JoshuaKGoldberg