Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow panning while animation is playing #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heese
Copy link

@heese heese commented Jan 18, 2018

The slider gets confused if an animation is playing (e.g., if you use a timeout to move to the next slide automatically) and the user pans the current slide. Usually, it ends up with two slides showing at the same time. I have introduced another flag indicating whether the user is panning around the current slide. The code does not allow for panning while an animation is playing and vice versa. There is also a new flag allowing for disabling manual slide changes.

I still can't run the demo and, therefore, cannot test the code in its native environment :-( Please, have a go -- any bugs should be easy to fix.

@JoshDSommer
Copy link
Owner

So I've really screwed up and made a bunch of changes to the project before merging this in. I'm sorry @heese the good news is I believe I have it set up so your local build and demo should work. it would probably be best to pull down a fresh clone of master and then re-apply this fix. If you don't want to or have time can my self here at some point. I'm sorry for the delay.

@heese
Copy link
Author

heese commented Feb 1, 2018

No worries. I am extremely busy at the moment and I might not find a spare time slot soon. I suggest whoever has some time to spare first goes for it and lets the other one know. I will surely keep this in my mind.

@JoshDSommer
Copy link
Owner

sounds good @heese thanks again 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants