-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serena branch for metadata from ArXiv #33
Open
sy2657
wants to merge
79
commits into
main
Choose a base branch
from
Serena-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q2_output and q4_output text files
jupyter notebook and same python functions
❌ Deploy Preview for data-ethics-tech failed. 🔨 Explore the source changes: 074e20f 🔍 Inspect the deploy log: https://app.netlify.com/sites/data-ethics-tech/deploys/612302ee96b8150008b92403 |
Serena, thanks for this. But could you fix these things?
|
Ok I will try. I think I did write more specific commit messages, but
somehow it printed the commit messages I made weeks ago.
…On Fri, Jul 23, 2021 at 6:13 PM Jonathan Reeve ***@***.***> wrote:
Serena, thanks for this. But could you fix these things?
- Rename this pull request from "Serena branch" to something semantic,
which describes what it is you're doing in this pull request.
- Put text files containing bibliographies in the data/texts/txt
directory
- Use .py files instead of .ipynb
- Remove all .ipynb_checkpoints files
- Make separate pull requests for separate issues, i.e. one pull
request for bibliographic text files, and another pull request for arXiv
interfacing
- Write commit messages that say what you're doing. You say "add files
via upload," but you need to say what it is you're doing in that commit,
and make it semantic. Maybe have a look through some of the tutorials
on how to write a commit message.
<https://duckduckgo.com/?q=how+to+write+a+good+git+commit+message&ia=web>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AONNUEJ2NMIZLVATHL6LUL3TZIHUZANCNFSM5A4S4JZA>
.
|
sy2657
changed the title
Serena branch for metdata from ArXiv
Serena branch for metadata from ArXiv
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functions for querying Arxiv: main_arxiv.py, editRatio.py, extractalphanumeric.py, queryArxiv.py, and jupyter notebook query_arxiv_metadata.