Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serena branch for metadata from ArXiv #33

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

Serena branch for metadata from ArXiv #33

wants to merge 79 commits into from

Conversation

sy2657
Copy link
Collaborator

@sy2657 sy2657 commented Jul 23, 2021

Adding functions for querying Arxiv: main_arxiv.py, editRatio.py, extractalphanumeric.py, queryArxiv.py, and jupyter notebook query_arxiv_metadata.

@netlify
Copy link

netlify bot commented Jul 23, 2021

❌ Deploy Preview for data-ethics-tech failed.

🔨 Explore the source changes: 074e20f

🔍 Inspect the deploy log: https://app.netlify.com/sites/data-ethics-tech/deploys/612302ee96b8150008b92403

@JonathanReeve
Copy link
Owner

JonathanReeve commented Jul 24, 2021

Serena, thanks for this. But could you fix these things?

  • Rename this pull request from "Serena branch" to something semantic, which describes what it is you're doing in this pull request.
  • Put text files containing bibliographies in the data/texts/txt directory
  • Use .py files instead of .ipynb
  • Remove all .ipynb_checkpoints files
  • Make separate pull requests for separate issues, i.e. one pull request for bibliographic text files, and another pull request for arXiv interfacing
  • Write commit messages that say what you're doing. You say "add files via upload," but you need to say what it is you're doing in that commit, and make it semantic. Maybe have a look through some of the tutorials on how to write a commit message.

@sy2657
Copy link
Collaborator Author

sy2657 commented Jul 25, 2021 via email

@sy2657 sy2657 changed the title Serena branch Serena branch for metdata from ArXiv Aug 10, 2021
@sy2657 sy2657 changed the title Serena branch for metdata from ArXiv Serena branch for metadata from ArXiv Aug 10, 2021
sy2657 added 30 commits August 22, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants