Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add directory node 'odpwaf…kptaid.onion' to defaults #1733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theborakompanioni
Copy link
Contributor

This PR adds directory node odpwaf67rs5226uabcamvypg3y4bngzmfk7255flcdodesqhsvkptaid.onion:5222 to the default list of directory nodes. See joinmarket-webui/jam-docker#126 for discussion.

Feedback to this node was that it has been online and reliable for a good amount of time. It has been mentioned by @roshii for the first time here: #1445 (comment)

@PulpCattel
Copy link
Member

I have nothing against adding a new directory per se, but:

  • When you say 🆗 you just mean "reachable" as per the curl command and Openoms script right? You did not actually try and/or received feedback of them working reliably when using actual JM scripts?
    Asking because that does not capture Directory nodes constantly disconnecting #1435. They are reachable but the connection is immediately dropped or something.
  • "online and reliable" is good, but I just want to point out again that this does not capture Directory nodes constantly disconnecting #1435. Do you know how many makers currently advertise themselves on this directory? I haven't checked (by commenting out all other directories and IRC) but I'd expect not many (20-30 perhaps?) so we should at least expect it will have similar issues.
  • If g3hv4uynnmynqqq2mchf3fcm3yd46kfzmcdogejuckgwknwyq5ya6iad.onion:5222 is not even reachable anymore, should we remove it in this PR? Is there a reason to keep it? Do we know if it's generally online or it's actually abandoned?

All this mostly to say that if we don't fix the underlying issue, we will simply end up with a longer and longer list of practically unusable directories.

@theborakompanioni
Copy link
Contributor Author

I have nothing against adding a new directory per se, but:

* When you say 🆗 you just mean "reachable" as per the `curl` command and Openoms script right? You did not actually try and/or received feedback of them working reliably when using actual JM scripts?
  1. Yes, the 🆗 sign means just that it is reachable.
  2. No, I did not test that myself - this is based on feedback from users.
  Asking because that does not capture [Directory nodes constantly disconnecting #1435](https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1435). They are reachable but the connection is immediately dropped or something.

True.

* "online and reliable" is good, but I just want to point out again that this does not capture [Directory nodes constantly disconnecting #1435](https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1435). Do you know how many makers currently advertise themselves on this directory? I haven't checked (by commenting out all other directories and IRC) but I'd expect not many (20-30 perhaps?) so we should at least expect it will have similar issues.

No, I don't know. I have not done further tests. Only that it is reachable.

* If `g3hv4uynnmynqqq2mchf3fcm3yd46kfzmcdogejuckgwknwyq5ya6iad.onion:5222` is not even reachable anymore, should we remove it in this PR? Is there a reason to keep it? Do we know if it's generally online or it's actually abandoned?

I am not able to answer these questions, as I have not done any further tests. Especially not over longer periods of time.

All this mostly to say that if we don't fix the underlying issue, we will simply end up with a longer and longer list of practically unusable directories.

Agree.

@overcoin
Copy link

This PR adds directory node odpwaf67rs5226uabcamvypg3y4bngzmfk7255flcdodesqhsvkptaid.onion:5222 to the default list of directory nodes. See joinmarket-webui/jam-docker#126 for discussion.

Feedback to this node was that it has been online and reliable for a good amount of time. It has been mentioned by @roshii for the first time here: #1445 (comment)

I would not recommend adding this node to the default list of directories. Indeed, it has been online for quite sometime but it is heavily manipulated as it constantly drops connections to peers in the middle of a coinjoin negotiation or privmsg exchange. Our log is full of blocks with 20-30 consecutive lines of:

Directory odpwaf67rs5226uabcamvypg3y4bngzmfk7255flcdodesqhsvkptaid.onion:5222 has lost connection to: J5...

Directories bql... and 3kx... are more difficult to connect to but once connected they are reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants