fix(network): deadlock in lwIP UDP handler's Close function #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a deadlock bug when a careless
PacketRequestSender
tries toClose
the correspondingPacketResponseReceiver
multiple times, here is the buggy flow chart:Note the recursive call path
(1)
:h.senders[laddr].Close()
will block becauseh.mu
has already be held, and it won'tUnlock()
untilh.senders[laddr].Close()
returns, this causes deadlock!This fix simply added a
closed
indicator inudpConnResponseWriter
to make sure only onecloseSession
will be called: