Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssconf support #268

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pmoieni
Copy link

@pmoieni pmoieni commented Aug 25, 2024

this PR adds support for ssconf transport URL to Outline CLI. I was not sure what to do with the prefix field so just left it untouched. I was not able to test the implementation either.

OutlineVPN CLI (experimental)
[INFO] 2024/08/25 15:12:11 updated global IPv6 support: false
[INFO] 2024/08/25 15:12:11 updated global IPv6 support: true
[ERROR] 2024/08/25 15:12:11 failed to create OutlineDevice: failed to create TCP dialer: failed to decode host string [ss:///redacted/@/redacted/:8080]: illegal base64 data at input byte 2

using the official access keys I get the above error.
no such issue while using ssconf key:

OutlineVPN CLI (experimental)
[INFO] 2024/08/25 15:58:38 updated global IPv6 support: false
[INFO] 2024/08/25 15:58:41 remote server cannot handle UDP traffic, switch to DNS truncate mode.
[INFO] 2024/08/25 15:58:41 routing traffic from 10.233.233.1 to 10.233.233.2/32 through nic 9
[INFO] 2024/08/25 15:58:41 routing traffic via gw 10.233.233.2 through nic 9...
[INFO] 2024/08/25 15:58:41 ip rule 'from all not to /redacted/ via table 233' created

but it doesn't seem to establish any kind of connection at all

OS: OpenSuse Tumbleweed

Copy link

google-cla bot commented Aug 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jyyi1
Copy link
Contributor

jyyi1 commented Sep 4, 2024

Thanks so much for this PR! We're currently migrating dynamic key feature into Go in Outline Client as well. To ensure the best integration, we'd appreciate a bit more time to review your PR and explore potential code sharing opportunities.

@pmoieni
Copy link
Author

pmoieni commented Sep 5, 2024

@jyyi1 looking forward to that, ready to improve the code if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants