Adds support for tenantId to MartenOps #1091
Draft
+340
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great feature, i have been missing this several times already! Mostly because we are stuck with a system with both Wolverine and non-Woverine services. |
|
@carcer Hey Chris, the code itself looks good, but because I didn't get this in before the 3.0 release, I need you to make overload methods instead of the optional parameters. Adding an optional parameter is a breaking API change even though it doesn't change anyone's code because it requires a re-compilation. Picky rules, but SemVer |
|
Fair, no problem, I'll get the change made soon 😊 thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Discord.
I have left the 2 different ways of applying the tenantId for feedback on which is the prefered way. I will update the PR accordingly, hence the PR being draft