Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Meshy" Fix #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Shadowkitten47
Copy link
Contributor

The plugin now uses events rather than recreating the Format.compile and other functions, Also comes with a pretty big bug fix. Fixing the x-axis invetation due to the pretty big changes I waited a ~week for people to find bugs but none.

@Shadowkitten47
Copy link
Contributor Author

Oh I also scraped that bundler thing because now that the code is much smaller it's easier to organize in a single file and works just fine

@JannisX11
Copy link
Owner

Nice that you managed to convert it to event hooks, that should make it easier to maintain.
I experienced several issues with function names not matching when loading the plugin. It looks like some functions are prefixed with "meshy", but they are referenced without that prefix. That's a breaking issue.
I also noticed issues with meshes having incorrect offsets if they had different pivot points. This affected both the in-game preview, and the scene in Blockbench if you re-opened the geometry file.

Original:
image

Reopened:
image

Minecraft:
image

@Shadowkitten47
Copy link
Contributor Author

Yea, added the prefix last second although I was sure I got them all. I also noticed issues with meshes having incorrect offsets if they had different pivot points. This is an issue in both the current version and past, I just don't know how to fix this issue sense the mesh position is fix to the origin but they also independent I really looked hard into the source but I couldn't find a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants