Replacement Vintage Story plugin #460
Conversation
Deprecate Animation To Java Converter
dont export unanimated groups
| var autosettings = []; | ||
| var namespace = {} | ||
|
|
||
| BBPlugin.register('vintagestory', { |
There was a problem hiding this comment.
The PR title makes it seem like this is an update to the existing Vintage Story plugin. But this is a completely new file, with a different ID. Also, the old plugin source was removed, but without any changes to the meta data.
There was a problem hiding this comment.
PR title updated, metadata updated
plugins/vintagestory/vintagestory.js
Outdated
| name: 'Vintage Story game folder', | ||
| description: 'Set this to the install path', | ||
| category: 'defaults', | ||
| value: process.env.APPDATA.replaceAll('\\', '/') + '/Vintagestory', |
There was a problem hiding this comment.
This plugin is tagged to work both on the desktop and the web app. Here, you are trying to access data that would only be available in the desktop app, which causes an error in the web app.
There was a problem hiding this comment.
tagged with desktop in plugin and metadata until I figure out how to switch setting_gamepath on/off based on variant
There was a problem hiding this comment.
only set the default if isApp and Windows
.gitignore
Outdated
| @@ -1,4 +0,0 @@ | |||
| node_modules/ | |||
There was a problem hiding this comment.
Please remove this change from the PR
plugins/vintagestory/vintagestory.js
Outdated
|
|
||
| BBPlugin.register('vintagestory', { | ||
| title: "Vintage Story", | ||
| author: "Malik12tree,Crabb", |
There was a problem hiding this comment.
Please separate different authors by a comma, followed by a space.
| icon: "park", | ||
| description: "Export and import of Vintage Story shapes", | ||
| tags: ["Vintage Story"], | ||
| version: "1.0.2", |
There was a problem hiding this comment.
The meta data was changed here, but the changes are not reflected in plugins.json.
plugins/vintagestory/vintagestory.js
Outdated
| image_editor: false, | ||
| integer_size: false, | ||
| java_face_properties: true, | ||
| locators: true, |
There was a problem hiding this comment.
Locators are enabled, but not handled. Is this on accident?
plugins/vintagestory/vintagestory.js
Outdated
| icon: 'park', | ||
| image_editor: false, | ||
| integer_size: false, | ||
| java_face_properties: true, |
There was a problem hiding this comment.
These are enabled, but none of the properties are actually used (shade, cullface, tint).
There was a problem hiding this comment.
turned off, thought I needed these for the java texture window but appears not to be required
merge back
|
Sorry this hasn't been looked at in a while. |
|
Looks perfect to me! |
|
Also, a maintainers:
- Malik12tree
- spooq |
|
Yup, the ID change would mean that users would no longer have the old plugin and would have to manually install the new one. Up to you @spooq, you can also just re-use the the current ID, it just needs to be consistently changed in all files and paths. |
Can't figure out the animation not working right on import. Saving and reopening the file works though