Improve VoxelShape Fabric Generator exporter #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the code generated by the VoxelShape Fabric Generator plugin by merging all individual shapes into a single one.
Old code generated:
```java
public VoxelShape makeShape(){
VoxelShape shape = VoxelShapes.empty();
shape = VoxelShapes.union(shape, VoxelShapes.cuboid(0.1875, 0, 0.375, 0.8125, 0.8125, 0.875));
shape = VoxelShapes.union(shape, VoxelShapes.cuboid(0.25, 0, 0.25, 0.75, 0.3125, 0.375));
shape = VoxelShapes.union(shape, VoxelShapes.cuboid(0.125, 0, 0.4375, 0.1875, 0.4375, 0.8125));
shape = VoxelShapes.union(shape, VoxelShapes.cuboid(0.8125, 0, 0.4375, 0.875, 0.4375, 0.8125));
return shape;
}
```
New generated code:
```java
public static VoxelShape makeShape() {
return VoxelShapes.union(
VoxelShapes.cuboid(0.1875, 0, 0.375, 0.8125, 0.8125, 0.875),
VoxelShapes.cuboid(0.25, 0, 0.25, 0.75, 0.3125, 0.375),
VoxelShapes.cuboid(0.125, 0, 0.4375, 0.1875, 0.4375, 0.8125),
VoxelShapes.cuboid(0.8125, 0, 0.4375, 0.875, 0.4375, 0.8125)
);
}
```
|
Looks good from my side. |
JannisX11
added
the
awaiting owner approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the code generated by the VoxelShape Fabric Generator plugin by merging all individual shapes into a single one.
Old generated code:
New generated code: