Merge pull request #648 from jasonjgardner/master

fix: PBR mode alphaTest value
JannisX11 · Nov 15, 2024 · 3702a79 · 3702a79
2 parents 152485a + a136850
commit 3702a79
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 3 deletions.
diff --git a/plugins.json b/plugins.json
@@ -1005,7 +1005,7 @@
 		"has_changelog": true,
 		"website": "https://github.com/jasonjgardner/blockbench-plugins/",
 		"variant": "both",
-		"version": "1.1.0",
+		"version": "1.2.1",
 		"tags": [
 			"Minecraft: Java Edition",
 			"Minecraft: Bedrock Edition",

diff --git a/plugins/pbr_preview/changelog.json b/plugins/pbr_preview/changelog.json
@@ -47,5 +47,19 @@
                 ]
             }
         ]
+    },
+    "1.2.1": {
+        "title": "1.2.1",
+        "date": "2024-11-10",
+        "author": "Jason J. Gardner",
+        "categories": [
+            {
+                "title": "Alpha Threshold Fix",
+                "list": [
+                    "Fixed alpha test threshold application on models.",
+                    "Alpha test value is 1%"
+                ]
+            }
+        ]
     }
 }
diff --git a/plugins/pbr_preview/pbr_preview.js b/plugins/pbr_preview/pbr_preview.js
diff --git a/src/pbr_preview/src/lib/PbrMaterials.ts b/src/pbr_preview/src/lib/PbrMaterials.ts
@@ -97,7 +97,7 @@ export default class PbrMaterial {
       emissive: emissiveMap ? 0xffffff : 0,
       envMap: PreviewScene.active?.cubemap ?? null,
       envMapIntensity: 0.95,
-      alphaTest: 0.1,
+      alphaTest: 0.01,
       transparent: true,
       ...options,
     });

diff --git a/src/pbr_preview/src/lib/applyPbrMaterial.ts b/src/pbr_preview/src/lib/applyPbrMaterial.ts
@@ -28,6 +28,7 @@ function applyToFace(
   ).getMaterial({
     side: Canvas.getRenderSide(texture) as THREE.Side,
     ...materialParams,
+    alphaTest: 0.01,
   });
 
   Project.materials[texture.uuid] = THREE.ShaderMaterial.prototype.copy.call(