fix(certbot): make cerbot honor httx_proxy #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
force-pushed
the
fix-certbot-with-proxy
branch
from
5e613cc
to
02b2f50
Compare
JanSkalny
reviewed
Aug 27, 2024
| when: proxy_host is defined and proxy_port is defined | ||
|
|
||
| - name: make systemd reread configs | ||
| ansible.builtin.systemd_service: |
There was a problem hiding this comment.
it would be nice if this would be conditional based on changed attribute from previous task
There was a problem hiding this comment.
lemme have a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR unbreaks
certboton proxied systems, where it is not able to talk to LetsEncrypt and fails to renew certs. setting the proxy values in its environment, it can now connect where it needs to.TODO
http_proxyis set at all.