Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not prematurely set Converter for Reader/Writer if CanRead/CanWrite is false #2692

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Do not prematurely set Converter for Reader/Writer if CanRead/CanWrite is false #2692

wants to merge 6 commits into from

Commits on Jun 8, 2022

  1. add ConverterOverrideTests

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    505b9e5 View commit details
    Browse the repository at this point in the history

  2. only set Reader converter is non-null converter .CanRead

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    2ff8db6 View commit details
    Browse the repository at this point in the history

  3. only set Writer converter is non-null converter .CanWrite

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3d5250e View commit details
    Browse the repository at this point in the history

  4. spacing fix

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c36ca50 View commit details
    Browse the repository at this point in the history

  5. remove unused import

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    04aa707 View commit details
    Browse the repository at this point in the history

  6. add newline to end of file because why not :)

    @forteddyt
    forteddyt committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    587508f View commit details
    Browse the repository at this point in the history