Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm wave and exp transmission loss variant #55

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

JakobEliasWagner
Copy link
Owner

@JakobEliasWagner JakobEliasWagner commented Aug 19, 2024

Description

Removes the wave and exp variant of the transmission loss dataset. The encoding performed by these datasets should either be performed during preprocessing or in the network itself.

Which issue does this PR tackle?

  • The exp and wave variant of the transmission loss dataset are hard to maintain.
  • Both operations performed by these variants of the compact dataset should be performed in a different place and are not responsibility of the dataset.

How does it solve the problem?

  • Removes exp and wave variant of the transmission loss dataset.

How are the changes tested?

  • Unit-tests:
    • Old unit tests run without new errors.

Checklist

  • Documentation
    • All new features include documentation
    • README is updated
  • CI/CD passes all pipeline checks
  • Post Merge
    • Delete the feature branch (if applicable).
    • Update related issues or project boards.

@JakobEliasWagner JakobEliasWagner merged commit c392a07 into main Aug 19, 2024
2 checks passed
@JakobEliasWagner JakobEliasWagner deleted the cleanup/remove-deprecated-features branch August 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant