Creates cycle indirection scenarios for tests #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfreivasc
force-pushed
the
gabrielfv/staging/indirection-tests
branch
from
a20b5e0 to
a8a8415
Compare
Creates `IndirectionCycle` with regular provided dependencies, `BindsIndirectionCycle` for bound dependencies indirection, and `MultibindProviderMapIndirectionCycle` for the scenario pinpointed in issue JakeWharton#175 and resolved by JakeWharton#198.
gfreivasc
force-pushed
the
gabrielfv/staging/indirection-tests
branch
from
a8a8415 to
7e778f4
Compare
|
There's a cycle test in upstream as well: dagger-reflect/integration-tests/upstream/build.gradle Lines 21 to 23 in dec8f8f But I guess this will never execute because #4 (comment) |
|
What do you think about testing cycles and checking that the instances actually end up the same when scoped? |
|
Quickly looking at it, it seems that perhaps some of these tests are okay to run. I'll take a look, since upstream currently covers two of the three tests. |
|
I think the test scenario and tests suffice, right? |
gfreivasc
force-pushed
the
gabrielfv/staging/indirection-tests
branch
from
aa56017 to
80de396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates
IndirectionCyclewith regular provided dependencies,BindsIndirectionCyclefor bound dependencies indirection, andMultibindProviderMapIndirectionCyclefor the scenario pinpointed in issue #175 and resolved by #198.