Add explicit close and context manager to Connection #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new close method that will close the session on a Connection object. However, ssh2-rs states that this will not close the underlying socket. If that's an issue in the future, perhaps we also track the TCP connection and close that along with the session. Since we're now allowing explicit closing, I also added a context manager to the Connection class, so people can handle that implicitly. I also bumped the supported Python versions included 3.13 (and pre-releases). Fixes #15
JacobCallahan
force-pushed
the
closing_time
branch
from
5b87a67
to
2f0f5f9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new close method that will close the session on a Connection object. However, ssh2-rs states that this will not close the underlying socket. If that's an issue in the future, perhaps we also track the TCP connection and close that along with the session.
Since we're now allowing explicit closing, I also added a context manager to the Connection class, so people can handle that implicitly.
Fixes #15