Use "as=fetch" in case no extension is matched (#46)

JacobBennett · Aug 17, 2020 · 5cc4186 · 5cc4186
1 parent 0e4705a
commit 5cc4186
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/src/Middleware/AddHttp2ServerPush.php b/src/Middleware/AddHttp2ServerPush.php
@@ -140,6 +140,9 @@ private function buildLinkHeaderString($url)
             return Str::contains(strtoupper($url), $extension);
         });
 
+        if ($url && !$type) {
+            $type = 'fetch';
+        }
 
         if(!preg_match('%^(https?:)?//%i', $url)) {
             $basePath = $this->getConfig('base_path', '/');

diff --git a/tests/AddHttp2ServerPushTest.php b/tests/AddHttp2ServerPushTest.php
@@ -98,6 +98,18 @@ public function it_will_return_an_image_link_header_for_svg_objects()
         $this->assertCount(1, explode(",", $response->headers->get('link')));
     }
 
+    /** @test */
+    public function it_will_return_a_fetch_link_header_for_fetch()
+    {
+        $request = new Request();
+
+        $response = $this->middleware->handle($request, $this->getNext('pageWithFetchPreload'));
+
+        $this->assertTrue($this->isServerPushResponse($response));
+        $this->assertStringContainsString('</api/resource>; rel=preload', $response->headers->get('link'));
+        $this->assertStringEndsWith("as=script", $response->headers->get('link'));
+    }
+
     /** @test */
     public function it_returns_well_formatted_link_headers()
     {

diff --git a/tests/fixtures/pageWithFetchPreload.html b/tests/fixtures/pageWithFetchPreload.html
@@ -0,0 +1,13 @@
+<html>
+
+    <head>
+        <title>Page title</title>
+        <link rel="preload" href="/api/resource" as="fetch">
+    </head>
+
+    <body>
+
+    <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.26/vue.min.js"></script>
+    </body>
+
+</html>