Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for delete endpoint #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JorisDebonnet
Copy link

@JorisDebonnet JorisDebonnet commented Oct 10, 2019

I've wanted this for a while, so just implemented it. I have tested it, works perfectly fine on my Sendy 4.0.3.2 installation, but should work on anything at or above 2.1.1.4!

Copy link

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

@ahmadawais
Copy link

@JorisDebonnet you can try my wrapper which is more complete and already has this function in case this PR doesn't go through https://github.com/ahmadawais/Sendy-PHP-API/blob/master/src/Sendy.php#L223-L255

@JorisDebonnet
Copy link
Author

https://github.com/ahmadawais/Sendy-PHP-API

Oh, interesting, will give that a look! Of course, this PR can still stay here for those other people still using this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants