Interpolate and group ais #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacob-Stevens-Haas
requested changes
Aug 9, 2021
| # then apply an interpolation function for each timepoint. The | ||
| # interpolation function will take a dataframe and a timepoint, | ||
| # and will determine, based on the nearest records before/after | ||
| # the timepoint, which interpolation rule to apply. | ||
| # | ||
| # While this function sounds like it takes a long time, its ok at | ||
| # the outset to accomplish this somewhat inefficiently. | ||
| mmsi_set = ais_df.groupby["mmsi"] |
There was a problem hiding this comment.
groupby is a function, needs parentheses (e.g. groupby("mmsi"))
Also, be careful naming things *_set when they're not a set object. Try mmsi_gb since this is a groupby object.
Comment on lines
+550
to
+552
| MWM: "near" = entries before and after the given time, | ||
| "very near" = one entry within a neighborhood of the given time | ||
|
|
There was a problem hiding this comment.
Not sure what the point of this is. These aren't definitions, despite the equals sign. These are cases when each term is used.
| time: when to interpolate the ship positions. | ||
| delta: the "very near" threshold | ||
| """ | ||
| time_col = mmsi["BaseDateTime"] |
There was a problem hiding this comment.
Try something like this, but faster:
for target_time in times:
last_before = max(obs_time - target_time for obs_time in time_col if obs_time < target_time)
first_after = min(obs_time - target_time for obs_time in time_col if obs_time > target_time)
if (
last_before
and target_time - last_before < near
and first_after
and first_after - target_time < near
):
# C1
elif last_before and target_time - last_before < very_near:
# C2
elif first_after and first_after - target_time < very_near:
# C2
Comment on lines
+582
to
+583
| time: when to interpolate the ship positions. | ||
| delta: the "very near" threshold |
There was a problem hiding this comment.
You need to do this for a list of times, so either _interpolate_and_group_ais() needs to apply this to each time, or _ais_interpolator_dispatcher() needs to take a list of times.
Also, you need deltas for the "near" and "very near" thresholds.
Comment on lines
+1
to
+10
| from tehom import downloads, _persistence | ||
|
|
||
|
|
||
| def test_download_ais_to_temp(declare_stateful): | ||
| year = 2014 | ||
| month = 1 | ||
| zone = 1 | ||
| downloads._download_ais_to_temp(year, month, zone) | ||
| path = _persistence.AIS_TEMP_DIR / f"{year}_{month}_{zone}.zip" | ||
| assert path.exists() |
Jacob-Stevens-Haas
force-pushed
the
master
branch
from
c4a4ca6
to
d66326a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.