Manage Python dependencies in requirements.txt
#1177
+45
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1177 +/- ##
=======================================
Coverage 24.96% 24.96%
=======================================
Files 170 170
Lines 19283 19283
=======================================
Hits 4814 4814
Misses 14469 14469 ☔ View full report in Codecov by Sentry. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
requirements.txtfile in thepythondirectory, simplifying the process of downloading dependencies necessary for building our Python module and executing automated tests. After merging this PR, executing the command below will install the required dependencies:> pip install -r python/requirements.txtThis change will also simplify the dependency management in our CI workflow by removing most of the hard coded Python dependencies from
.github/workflows/cpp-python-build.yml.This PR also caches the Python dependencies used by our CI workflow. This is to reduce the workload on the PyPI servers as explained in the blog post Let's go easy on PyPI, OK ?. Although JSBSim is most likely a very minor contributor to the bandwidth demand for PyPI, this PR will help minimize as much as we can the bandwidth usage from PyPI.