Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight improvements to the build system #1

Closed
wants to merge 2 commits into from

Conversation

viroulep
Copy link

Here are a few fixes to the issues I encountered when building the project:

  • nlohmann's json library has a quite huge repository, since the goal is not to make changes to the dependencies it's probably fine to shallow clone them.
  • when using gcc/clang with an (old?) install of libstd++ (shipped with gcc 8), adding stdc++fs is necessary for the project to link properly. I'm not sure if it's still needed in more recent versions.
  • when compiling projects linking with LLVM, I think -fno-rtti is necessary because LLVM builds without RTTI.

@JPenuchot
Copy link
Owner

Sorry I missed the notification for this PR. I pushed these modifications to the project myself since it has changed a lot. Thank you!

@JPenuchot JPenuchot closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants