Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings added to I/O piplines #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecation warnings added to I/O piplines #490

wants to merge 1 commit into from

Conversation

ilia-zaitcev-by
Copy link
Contributor

@ilia-zaitcev-by ilia-zaitcev-by commented Aug 4, 2021 •
edited
Loading

Description

Added missing deprecation warnings for keyword arguments:

  • label_filter
  • central_partition_metadata
  • load_dynamic_metadata
  • load_dataset_metadata
  • concat_partitions_on_primary_index

These parameters will be excluded in the next major release (6.x).

steffen-schroeder-by
steffen-schroeder-by approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@steffen-schroeder-by steffen-schroeder-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite some pre-commit errors, this looks good to me.
Can you please fix those? If everything is green, you can merge this yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffen-schroeder-by steffen-schroeder-by steffen-schroeder-by approved these changes

@fjetter fjetter Awaiting requested review from fjetter

@pavankumar-jamanjyothi-by pavankumar-jamanjyothi-by Awaiting requested review from pavankumar-jamanjyothi-by

@aaron-tal-by aaron-tal-by Awaiting requested review from aaron-tal-by

@jakob-ernst-by jakob-ernst-by Awaiting requested review from jakob-ernst-by

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia-zaitcev-by @steffen-schroeder-by