Testing code moved from kartothek.io.testing to tests.* #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy cubes by selecting and copying the individual datasets
Added PR 450 as a requirement in the comment. (makes things easier...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The module kartothek.io.testing contained lots of unit tests. This is grown historically (support for kartothek-yamal).
This change moves the tests to the tests folder, where one would expect to find them. The new test structure is as follows:
tests.io.eager,tests.io.iter,tests.io.dask.bag,tests.io.dask.dataframe,tests.io.dask.delayed: These are tests which are specific for one Kartothek implementation backend. Other than before, the test files contained in these modules will execute only the tests contained directly in the test file, and import no more tests from other packages.tests.io.common: These are tests which span multiple backend implementations. That is, each one of these tests is executed for more than one backend implementation - however, not all tests make sense for every backend implementation.The existing backend implementations are controlled using the fixture
backend_identifier. As it was before, the tests rely on abound_xxxfixture which encapsulates the actual implementation of the functionality to be tested. I.e. abound_readfixture may encapsulate an eager read, a dask dataframe read, etc., depending on the current value of thebackend_identifierfixture.If a specific implementation does not exist for a specific backend identifier, the test is skipped using
pytest.skip()in thebound_xxxfixture. This leads in fact to a relatively large number of tests to be skipped, since pytest tries to execute the tests for all possible combinations of backend identifiers.tests.io.cube: Tests for cube functionalities. These tests contain (as before) a fixture calleddriverto encapsulate the different backend implementations. When a specific functionality is not implemented for one driver, the test is skipped.Note: Current version contains #450; this one should be merged first.
BY internal: Refers to JIRA task LDE-714.