Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode animation names #92

Open
mrwonko opened this issue Apr 12, 2013 · 4 comments
Open

Don't hardcode animation names #92

mrwonko opened this issue Apr 12, 2013 · 4 comments

Comments

@mrwonko
Copy link
Contributor

mrwonko commented Apr 12, 2013

I believe the animation names (BOTH_STAND1 etc.) are hardcoded. That's why there's BOTH_CIN* for level-specific cinematic animations. It would be nice if the names were not hardcoded, and you could just add a new one by listing it in animation.cfg.

The .ibi format does not need to be changed, the animation names are saved as strings in there anyway. It's not until ingame that they're presumably turned into an enum.

@eezstreet
Copy link
Contributor

I concur.

Sent from my Windows Phone


From: Willi Schinmeyermailto:[email protected]
Sent: ‎4/‎12/‎2013 7:53 AM
To: Razish/OpenJKmailto:[email protected]
Subject: [OpenJK] Don't hardcode animation names (#92)

I believe the animation names (BOTH_STAND1 etc.) are hardcoded. That's why there's BOTH_CIN* for level-specific cinematic animations. It would be nice if the names were not hardcoded, and you could just add a new one by listing it in animation.cfg.

The .ibi format does not need to be changed, the animation names are saved as strings in there anyway. It's not until ingame that they're presumably turned into an enum.


Reply to this email directly or view it on GitHub:
#92

@dusty22
Copy link

dusty22 commented Apr 12, 2013

Would this mean you could add new animations without having to code new slots?!

@eezstreet
Copy link
Contributor

Yes.

Date: Fri, 12 Apr 2013 14:54:08 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [OpenJK] Don't hardcode animation names (#92)

Would this mean you could add new animations without having to code new slots?!


Reply to this email directly or view it on GitHub.

@mrwonko
Copy link
Contributor Author

mrwonko commented Apr 13, 2013

Though without coding they could only be used in Cutscenes.

@mrwonko mrwonko mentioned this issue Mar 25, 2016
12 tasks
TomArrow pushed a commit to TomArrow/jaPRO that referenced this issue Jan 19, 2024
* jetpack hackscale fix, jetapck fuel regen delay, punting fix

(cherry picked from commit 50cfc79)

* passive heal

(cherry picked from commit f410bcd)

* fix i guess

(cherry picked from commit c06352f)

---------

Co-authored-by: videoP <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants