Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to expect no binding by keyword to *args/**kwargs #1042

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Update tests to expect no binding by keyword to *args/**kwargs #1042

merged 2 commits into from
Nov 18, 2020

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Nov 18, 2020

slozier
slozier approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This means that we can remove the unicode char from all the arguments that use the ParamDictionaryAttribute?

@BCSharp
Copy link
Member Author

BCSharp commented Nov 18, 2020

That's right. I've seen it also being used sometimes on parameters with ParamArrayAttribute (e.g. BaseException.__init__), that could go now too.

@slozier slozier merged commit d32a2b5 into IronLanguages:master Nov 18, 2020
@BCSharp BCSharp deleted the nonkeyword_params branch November 18, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier approved these changes

Assignees
No one assigned
Labels
Port to ipy2.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCSharp @slozier