Skip to content

Commit

Permalink
Fix missing version directive not showing errored program
Browse files Browse the repository at this point in the history
  • Loading branch information
@IMS212
IMS212 committed Jul 16, 2023
1 parent 41679d9 commit 0c96678
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/net/coderbot/iris/pipeline/transform/TransformPatcher.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ private static Map<PatchShaderType, String> transformInternal(
Parameters parameters) {
try {
return transformer.transform(inputs, parameters);
} catch (TransformationException | ParsingException | ParseCancellationException e) {
} catch (TransformationException | ParsingException | IllegalStateException | IllegalArgumentException e) {
// print the offending programs and rethrow to stop the loading process
ShaderPrinter.printProgram("errored_program").addSources(inputs).print();
throw e;
Expand Down

3 comments on commit 0c96678

@douira
Copy link
Member

@douira douira commented on 0c96678 Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was ParseCancellationException removed as an exception being handled?

@IMS212
Copy link
Member Author

@IMS212 IMS212 commented on 0c96678 Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an IllegalStateException

@douira
Copy link
Member

@douira douira commented on 0c96678 Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's slightly confusing

Please sign in to comment.